Skip to content

[PID ML] Separate models for different momentum#479

Merged
saganatt merged 6 commits into
AliceO2Group:masterfrom
Lukaszz99:pidML
Jan 27, 2022
Merged

[PID ML] Separate models for different momentum#479
saganatt merged 6 commits into
AliceO2Group:masterfrom
Lukaszz99:pidML

Conversation

@Lukaszz99

@Lukaszz99 Lukaszz99 commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

No description provided.

saganatt
saganatt requested changes Jan 26, 2022
View reviewed changes
Comment thread Tools/PIDML/qaPidML.cxx Outdated
Comment thread Tools/PIDML/qaPidML.cxx Outdated
Comment thread Tools/PIDML/qaPidML.cxx Outdated
Comment thread Tools/PIDML/qaPidML.cxx Outdated
@alibuild

alibuild commented Jan 26, 2022

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 0908236 at 2022-01-26 22:20:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:356:84: error: 'True' was not declared in this scope
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:360:84: error: 'False' was not declared in this scope
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:326:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:328:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:326:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:328:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:326:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:328:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jan 26, 2022

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for c5c542c at 2022-01-26 22:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:359:84: error: 'True' was not declared in this scope
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:363:84: error: 'False' was not declared in this scope
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:330:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:332:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:330:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:332:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:330:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:332:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jan 26, 2022

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 8f9e033 at 2022-01-26 22:40:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:330:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:332:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:330:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:332:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:330:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:332:20: error: cannot convert '<brace-enclosed initializer list>' to 'float' in assignment
ninja: build stopped: subcommand failed.

Full log here.

saganatt
saganatt previously approved these changes Jan 26, 2022
View reviewed changes
@saganatt saganatt enabled auto-merge (squash) January 26, 2022 23:08
@alibuild

alibuild commented Jan 26, 2022

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for d63804c at 2022-01-27 00:13:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:330:17: error: assigning to an array from an initializer list
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:332:17: error: assigning to an array from an initializer list
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:330:17: error: assigning to an array from an initializer list
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:332:17: error: assigning to an array from an initializer list
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:330:17: error: assigning to an array from an initializer list
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:332:17: error: assigning to an array from an initializer list
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jan 27, 2022

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 08ffec7 at 2022-01-27 01:41:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:330:17: error: assigning to an array from an initializer list
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:332:17: error: assigning to an array from an initializer list
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:330:17: error: assigning to an array from an initializer list
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:332:17: error: assigning to an array from an initializer list
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:330:17: error: assigning to an array from an initializer list
/sw/SOURCES/O2Physics/479-slc7_x86-64/0/Tools/PIDML/qaPidML.cxx:332:17: error: assigning to an array from an initializer list
ninja: build stopped: subcommand failed.

Full log here.

auto-merge was automatically disabled January 27, 2022 06:24

Head branch was pushed to by a user without write access

@saganatt saganatt enabled auto-merge (squash) January 27, 2022 12:44
@saganatt saganatt self-requested a review January 27, 2022 12:44
@saganatt saganatt merged commit a3d52bb into AliceO2Group:master Jan 27, 2022
@saganatt

saganatt commented Jan 27, 2022

Copy link
Copy Markdown
Collaborator

macOS error unrelated

AnnalenaKa pushed a commit to AnnalenaKa/O2Physics that referenced this pull request Jan 30, 2022
@Lukaszz99 @AnnalenaKa
[PID ML] Separate models for different momentum (AliceO2Group#479)
d5daa73 
* add separate models for different momentum

* Add array with momentum threshold values

* True -> true

* Fix error with list initialization

* chang <= to =

* change initialization method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saganatt saganatt saganatt approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lukaszz99 @alibuild @saganatt